ripd: fix authentication key length #9191

idryzhov · 2021-07-26T19:32:26Z

We were overwriting the last byte of the key when it's exactly 16 bytes.

Signed-off-by: Igor Ryzhov [email protected]

qlyoung · 2021-07-26T19:46:00Z

ripd/ripd.c

+		/*
+		 * strncpy is intentional. auth_str should be NULL-terminated
+		 * only when key->string length is less than sizeof(auth_str).
+		 */


If this is a fixed size buffer why does it need to be null terminated at all?

We don't really care about the NULL-byte, but we have to somehow cover the case when the source string is less than 16 bytes. We could manually check the source string length and do something like:

len = strlen(key->string); if (len > sizeof(auth_str)) len = sizeof(auth_str); memcpy(auth_str, key->string, len);

But strncpy already does what we need so why not use it?

Replaced with memcpy as strncpy doesn't pass the CI.

LabN-CI · 2021-07-26T20:01:34Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/9191 `36cc906`
Date	07/26/2021
Start	15:35:56
Finish	16:01:29
Run-Time	25:33
Total	1813
Pass	1813
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-07-26-15:35:56.txt
Log	autoscript-2021-07-26-15:37:12.log.bz2
Memory	490 518 430

For details, please contact louberger

NetDEF-CI · 2021-07-26T20:10:24Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20552/frr-source'
In function rip_auth_md5,
ripd/ripd.c:930:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
ripd/ripd.c:927:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9976: ripd/ripd.o] Error 1
/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB11AMD64/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from /usr/include/string.h:495,
In function strncpy,
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: __builtin_strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
In function strncpy,
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: __builtin_strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9973: ripd/ripd.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/U2004AMD64BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CI009BUILD/ErrorLog/log_make.txt)

 1033 | static void elffile_add_dynreloc(struct elffile *w, Elf_Data *reldata,
In function 'rip_auth_md5',
ripd/ripd.c:930:3: error: 'strncpy' specified bound 16 equals destination size [-Werror=stringop-truncation]
ripd/ripd.c:927:3: error: 'strncpy' specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:9975: ripd/ripd.o] Error 1
/usr/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/usr/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/usr/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CI009BUILD/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20552/frr-source'
In function rip_auth_md5.isra.15,
ripd/ripd.c:930:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
ripd/ripd.c:927:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9972: ripd/ripd.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.20552/frr-source'

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/F29BUILD/config.log/config.log.gz

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20552/frr-source'
In function rip_auth_md5.isra.15,
ripd/ripd.c:930:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
ripd/ripd.c:927:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9972: ripd/ripd.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.20552/frr-source'

CentOS 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CENTOS8BUILD/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20552/frr-source'
In function rip_auth_md5.isra.15,
ripd/ripd.c:930:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
ripd/ripd.c:927:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9973: ripd/ripd.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.20552/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB10BUILD/config.status/config.status

Successful on other platforms/tests

NetBSD 8 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 16.04 i386 build
Ubuntu 18.04 amd64 build
Ubuntu 18.04 arm8 build
CentOS 7 amd64 build
Ubuntu 18.04 arm7 build
Debian 9 amd64 build
Ubuntu 18.04 ppc64le build
OpenBSD 6 amd64 build
Ubuntu 16.04 arm8 build
Ubuntu 16.04 arm7 build
Ubuntu 18.04 i386 build
FreeBSD 12 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20552/frr-source'
In function rip_auth_md5,
ripd/ripd.c:930:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
ripd/ripd.c:927:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9976: ripd/ripd.o] Error 1
/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB11AMD64/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from /usr/include/string.h:495,
In function strncpy,
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: __builtin_strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
In function strncpy,
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: __builtin_strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9973: ripd/ripd.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/U2004AMD64BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CI009BUILD/ErrorLog/log_make.txt)

 1033 | static void elffile_add_dynreloc(struct elffile *w, Elf_Data *reldata,
In function 'rip_auth_md5',
ripd/ripd.c:930:3: error: 'strncpy' specified bound 16 equals destination size [-Werror=stringop-truncation]
ripd/ripd.c:927:3: error: 'strncpy' specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:9975: ripd/ripd.o] Error 1
/usr/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/usr/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/usr/home/ci/cibuild.20552/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CI009BUILD/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20552/frr-source'
In function rip_auth_md5.isra.15,
ripd/ripd.c:930:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
ripd/ripd.c:927:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9972: ripd/ripd.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.20552/frr-source'

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/F29BUILD/config.log/config.log.gz

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20552/frr-source'
In function rip_auth_md5.isra.15,
ripd/ripd.c:930:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
ripd/ripd.c:927:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9972: ripd/ripd.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.20552/frr-source'

CentOS 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/CENTOS8BUILD/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.20552/frr-source'
In function rip_auth_md5.isra.15,
ripd/ripd.c:930:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
ripd/ripd.c:927:3: error: strncpy specified bound 16 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9973: ripd/ripd.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.20552/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20552/artifact/DEB10BUILD/config.status/config.status

Report for ripd.c | 12 issues
===============================================
< WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#927: FILE: /tmp/f1-6182/ripd.c:927:
< +		strncpy(auth_str, key->string, sizeof(auth_str));
< 
< WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#930: FILE: /tmp/f1-6182/ripd.c:930:
< +		strncpy(auth_str, ri->auth_str, sizeof(auth_str));
< 
< WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#977: FILE: /tmp/f1-6182/ripd.c:977:
< +		strncpy(auth_str, key->string, len);
< 
< WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#979: FILE: /tmp/f1-6182/ripd.c:979:
< +		strncpy(auth_str, ri->auth_str, len);
<

LabN-CI · 2021-07-27T08:16:43Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/9191 `41abe95`
Date	07/27/2021
Start	03:51:00
Finish	04:16:38
Run-Time	25:38
Total	1813
Pass	1813
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-07-27-03:51:00.txt
Log	autoscript-2021-07-27-03:52:22.log.bz2
Memory	489 474 430

For details, please contact louberger

NetDEF-CI · 2021-07-27T08:19:23Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20559/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20559/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20559/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20559/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
ripd/ripd.c:970:33: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare]
/usr/include/sys/param.h:192:23: note: expanded from macro 'MIN'
#define MIN(a,b) (((a)<(b))?(a):(b))
ripd/ripd.c:972:34: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare]
/usr/include/sys/param.h:192:23: note: expanded from macro 'MIN'
#define MIN(a,b) (((a)<(b))?(a):(b))
2 errors generated.

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20559/artifact/CI011BUILD/config.status/config.status
OpenBSD 6 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20559/artifact/CI011BUILD/config.log/config.log.gz

Successful on other platforms/tests

Ubuntu 18.04 arm7 build
Ubuntu 18.04 ppc64le build
Debian 9 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 16.04 arm8 build
Ubuntu 16.04 i386 build
Fedora 29 amd64 build
Debian 11 amd64 build
CentOS 7 amd64 build
CentOS 8 amd64 build
Ubuntu 18.04 arm8 build
Ubuntu 16.04 arm7 build
FreeBSD 12 amd64 build
Debian 10 amd64 build
NetBSD 8 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 18.04 amd64 build
FreeBSD 11 amd64 build

We were overwriting the last byte of the key when it's exactly 16 bytes. Fixes FRRouting#8151. Signed-off-by: Igor Ryzhov <[email protected]>

LabN-CI · 2021-07-27T09:16:42Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/9191 `b5b4f44`
Date	07/27/2021
Start	04:50:55
Finish	05:16:37
Run-Time	25:42
Total	1813
Pass	1813
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-07-27-04:50:55.txt
Log	autoscript-2021-07-27-04:52:12.log.bz2
Memory	520 498 429

For details, please contact louberger

idryzhov · 2021-07-27T09:29:49Z

@Mergifyio backport stable/8.0

mergify · 2021-07-27T09:30:21Z

Command backport stable/8.0: pending

Waiting for the pull request to get merged

idryzhov · 2021-07-27T12:12:09Z

ci:rerun

NetDEF-CI · 2021-07-27T12:50:18Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20562/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO1DEB10AMD64-20562/test

Topology Tests failed for Topotests debian 10 amd64 part 1:

2021-07-27 09:07:18,248 ERROR: 'router_json_cmp' failed after 130.71 seconds
2021-07-27 09:07:18,250 ERROR: assert failed at "bfd_topo2.test_bfd_topo2/test_protocols_convergence": "r4" JSON output mismatches
assert Generated JSON diff error report:
  
  > $: d2 has key '2001:db8:1::/64' which is not present in d1
2021-07-27 09:24:05,655 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/bgp.py", line 204, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
% Specify remote-as or peer-group commands first
line 7: Failure to communicate[13] to bgpd, line: neighbor 10.0.0.13 timers 3 10 

line 9: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 11: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 timers 3 10 

% Specify remote-as or peer-group commands first
line 14: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2021-07-27 09:24:06,267 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/bgp.py", line 204, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2021-07-27 09:28:23,026 ERROR: r4: zebra left a dead pidfile (pid=15431)

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20562/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests debian 10 amd64 part 7
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 2
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 amd64 part 6
Debian 9 deb pkg check
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 3
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 8
IPv4 ldp protocol on Ubuntu 18.04
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 i386 part 8
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 i386 part 4
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests debian 10 amd64 part 9
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 4
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 amd64 part 5
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 6
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 4
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 4

idryzhov · 2021-07-27T13:08:28Z

ci:rerun

NetDEF-CI · 2021-07-27T17:32:53Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20568/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-20568/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1:

2021-07-27 13:18:03,006 ERROR: 'router_json_cmp' failed after 150.62 seconds
2021-07-27 13:18:03,013 ERROR: assert failed at "bfd_topo2.test_bfd_topo2/test_protocols_convergence": "r4" JSON output mismatches
assert Generated JSON diff error report:
  
  > $: d2 has key '2001:db8:1::/64' which is not present in d1
2021-07-27 13:51:26,322 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 204, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
% Specify remote-as or peer-group commands first
line 7: Failure to communicate[13] to bgpd, line: neighbor 10.0.0.13 timers 3 10 

line 9: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 11: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 timers 3 10 

% Specify remote-as or peer-group commands first
line 14: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2021-07-27 13:51:27,192 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 204, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20568/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1804AMD64-20568/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4:

2021-07-27 13:32:03,231 ERROR: r1: zebra left a dead pidfile (pid=2168)
2021-07-27 13:36:18,136 ERROR: r2: bgpd left a dead pidfile (pid=12645)
2021-07-27 13:40:55,191 ERROR: ce3: bgpd left a dead pidfile (pid=17372)
2021-07-27 13:43:55,622 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2021-07-27 13:43:55,932 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2021-07-27 13:43:56,214 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2021-07-27 13:43:56,581 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2021-07-27 13:43:58,661 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 1:a:2 



2021-07-27 13:48:00,016 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



2021-07-27 13:50:52,775 ERROR: r1: bgpd left a dead pidfile (pid=25139)
r3: Daemon bgpd not running

From frr r3 bgpd log file:
2021/07/27 13:51:06 BGP: [HG1WF-2N96F] YANG model "ietf-yang-types@*" "*@*"not embedded, trying external file
2021/07/27 13:51:06 BGP: [HG1WF-2N96F] YANG model "ietf-inet-types@*" "*@*"not embedded, trying external file
2021/07/27 13:51:06 BGP: [T83RR-8SM5G] bgpd 8.1-dev starting: vty@2605, [email protected]:179, [email protected]:179
2021/07/27 13:51:07 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/07/27 13:51:09 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/27 13:51:09 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/07/27 13:51:09 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/07/27 13:51:09 BGP: [M7Q4P-46WDR] vty[??]@(config)# router bgp 2000 

2021/07/27 13:51:09 BGP: [WNS64-X9NY5][EC 100663299] bind: Cannot assign requested address
2021/07/27 13:51:09 BGP: [HHAYK-1Y778][EC 100663299] bgp_socket: no usable addresses please check other programs usage of specified port 179
2021/07/27 13:51:09 BGP: [VD9ME-QCNTF][EC 100663299] bgp_socket: Program cannot continue

2021-07-27 13:51:11,447 ERROR: assert failed at "test_bgp_listen_on_multiple_addresses/test_peering": r3: Daemon bgpd not running

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20568/artifact/TP4U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 7
Ubuntu 16.04 deb pkg check
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 6
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Debian 9 deb pkg check
CentOS 7 rpm pkg check
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 3
Static analyzer (clang)
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 arm8 part 0
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 5
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 9
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 arm8 part 9
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 9
IPv6 protocols on Ubuntu 18.04
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 7
Topotests debian 10 amd64 part 6
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 i386 part 2
Addresssanitizer topotests part 8

idryzhov · 2021-07-27T17:38:34Z

ci:rerun

NetDEF-CI · 2021-07-27T19:39:40Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20572/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 6
Ubuntu 16.04 deb pkg check
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 2
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
CentOS 7 rpm pkg check
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 9
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 9
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 0
IPv4 ldp protocol on Ubuntu 18.04
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 3
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
IPv6 protocols on Ubuntu 18.04
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 6
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 7
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 i386 part 7

idryzhov · 2021-07-27T19:49:43Z

I hate this.

idryzhov · 2021-07-27T19:49:49Z

ci:rerun

NetDEF-CI · 2021-07-27T23:58:22Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20582/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2021-07-28T01:22:16Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20587/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

idryzhov · 2021-07-29T12:21:36Z

@qlyoung could you please take a look?

rwestphal

LGTM

riw777

looks good

mergify · 2021-08-03T13:29:46Z

Command backport stable/8.0: success

Backports have been created

#9267 ripd: fix authentication key length (backport #9191) has been created for branch stable/8.0

ripd: fix authentication key length (backport #9191)

polychaeta added bugfix rip labels Jul 26, 2021

qlyoung reviewed Jul 26, 2021

View reviewed changes

idryzhov force-pushed the rip-auth branch from 36cc906 to 41abe95 Compare July 27, 2021 07:45

ripd: fix authentication key length

b5b4f44

We were overwriting the last byte of the key when it's exactly 16 bytes. Fixes FRRouting#8151. Signed-off-by: Igor Ryzhov <[email protected]>

idryzhov force-pushed the rip-auth branch from 41abe95 to b5b4f44 Compare July 27, 2021 08:23

idryzhov requested a review from qlyoung July 28, 2021 17:40

rwestphal approved these changes Aug 3, 2021

View reviewed changes

riw777 approved these changes Aug 3, 2021

View reviewed changes

riw777 merged commit cdc549b into FRRouting:master Aug 3, 2021

mergify bot mentioned this pull request Aug 3, 2021

ripd: fix authentication key length (backport #9191) #9267

Merged

donaldsharp added a commit that referenced this pull request Aug 4, 2021

Merge pull request #9267 from FRRouting/mergify/bp/stable/8.0/pr-9191

89bfb34

ripd: fix authentication key length (backport #9191)

ripd: fix authentication key length #9191

ripd: fix authentication key length #9191

Conversation

idryzhov commented Jul 26, 2021 • edited Loading

qlyoung Jul 26, 2021

Choose a reason for hiding this comment

idryzhov Jul 26, 2021 • edited Loading

Choose a reason for hiding this comment

idryzhov Jul 27, 2021

Choose a reason for hiding this comment

LabN-CI commented Jul 26, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 26, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Jul 27, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 27, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

LabN-CI commented Jul 27, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

idryzhov commented Jul 27, 2021

mergify bot commented Jul 27, 2021

idryzhov commented Jul 27, 2021

NetDEF-CI commented Jul 27, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

idryzhov commented Jul 27, 2021

NetDEF-CI commented Jul 27, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

idryzhov commented Jul 27, 2021

NetDEF-CI commented Jul 27, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

idryzhov commented Jul 27, 2021

idryzhov commented Jul 27, 2021

NetDEF-CI commented Jul 27, 2021 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Jul 28, 2021

Continuous Integration Result: SUCCESSFUL

idryzhov commented Jul 29, 2021

rwestphal left a comment

Choose a reason for hiding this comment

riw777 left a comment

Choose a reason for hiding this comment

mergify bot commented Aug 3, 2021

idryzhov commented Jul 26, 2021 •

edited

Loading

idryzhov Jul 26, 2021 •

edited

Loading

LabN-CI commented Jul 26, 2021 •

edited

Loading

NetDEF-CI commented Jul 26, 2021 •

edited

Loading

LabN-CI commented Jul 27, 2021 •

edited

Loading

NetDEF-CI commented Jul 27, 2021 •

edited

Loading

NetDEF-CI commented Jul 27, 2021 •

edited

Loading

NetDEF-CI commented Jul 27, 2021 •

edited

Loading

NetDEF-CI commented Jul 27, 2021 •

edited

Loading

NetDEF-CI commented Jul 27, 2021 •

edited

Loading