bgpd: associate correct nexthop when using peer link-local (backport #8961) #9146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
When setting bgp configuration using peers referencing link local ipv6 addresses, the bgp should be able to handle incoming bgp connections, and find out the appropriate interface where the connection comes from. ipv6 link local sessions work by using bgp unnumbered interfaces config, but it does not work if we have a shared media with multiple potential link local ipv6 addresses on the network. The fix consists in finding out the appropriate interface, when the local configuration references a link local ipv6 addresses, and the source address used references an interface. below configuration illustrates what can be done then: neighbor fe80::4113:5bba:2b61:b20c remote-as 55 neighbor fe80::4113:5bba:2b61:b20c update-source eth0 note: this change does not solve the ability for such config to create an outgoing connection to remote peer (as the link local ipv6 address config does not indicate which interface to use). Signed-off-by: Philippe Guibert <[email protected]> (cherry picked from commit abe6805)
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20462/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #8961 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/