Reload with routemaps (backport #8337) #9138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
When using frr-reload.py to modify a bgp neighbors route-map the code was doing this: a) deleting the previous route-map: `no neighbor XX route-map YY (in|out)` b) Adding the new route-map back in `neighbor XX route-may ZZ (in|out)` Now imagine that we have an outgoing route-map that we are changing and the reload is large because of a large number of lines in frr.conf Item (a) will happen. BGP will immediately start sending all local routes. At some point in time in the future (b) will be applied. This of course causes a withdraw but for a short amount of time we are leaking unintended routes. This is bad for several reasons not 1) route churn upstream, 2) we might influence traffic to go the wrong way. 3) if upstream has a maximum-prefix command the routes being sent might trip its circuitry and shutdown the peer entirely not even allowing you to get to (b). Ticket: #2589685 Signed-off-by: Donald Sharp <[email protected]> (cherry picked from commit 6293c21)
Merged
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20454/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #8337 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/