ospf6d: Release last dbdesc packet after router dead interval (backport #8334) #9134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
During the database description exchange process, the slave releases the last dbdesc packet after router_dead_interval. This was not implemented in the code. I have written the function ospf6_neighbor_last_dbdesc_release, which releases the last dbdesc packet after router_dead_interval. This change was required as per the conformance test 13.11: In state Full reception of a Database Description packet from the master after this interval (RouterDeadInterval) will generate a SeqNumberMismatch neighbor event. Associated Parameters ICMPv6 Packet Listen Time ICMPv6 Packet Tolerance Factor ICMPv6 Packet Tolerance Time OSPFV3 DUT Interface Transmit Delay OSPF Reset Adjacencies Timeout Test Actions 1. 2. 3. ANVL: Establish full adjacency with DUT for neighbor Rtr-0-A on DIface-0, with DUT as slave. ANVL: Wait (for <RouterDeadInterval> seconds). ANVL: Send <OSPF-DD> packet from neighbor Rtr-0-A to DIface-0 con- taining: • • I-bit field not set M-bit field not set MS-bit field set DD sequence number same as the one last sent by ANVL. . ANVL: Listen (for upto 2 * <RxmtInterval> seconds) on DIface-0. 5. DUT: Trigger the event SeqNumberMismatch and set the neighbor state for neighbor Rtr-0-A to ExStart. 6. DUT: Send <OSPF-DD> packet. 7. ANVL: Verify that the received <OSPF-DD> packet contains: • I-bit field set • M-bit field set • MS-bit field set. Test Reference • RFC 5340, s4.2.1.2 p19 Sending Database Description Packets RFC 2328, s10.8 p104 Sending Database Description Packets. Signed-off-by: Yash Ranjan <[email protected]> (cherry picked from commit bc09f3e)
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20450/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #8334 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/