ospf6d: route-map config changed, not getting applied on all types of… (backport #8954) #9118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
… routes Problem Statement: ================== when route-map config is changed from permit to deny, it is not getting applied to both connected and static and vice versa RCA: ================== When route-map changes from permit to deny or vice versa, a notification is sent to ospf6 daemon via ospf6_asbr_routemap_update. In this function, a thread is scheduled after 5 seconds to apply the route-map changes. In this thread (ospf6_asbr_routemap_update_timer), only the first type is passed as argument and only the first type i.e "connected" is passed and hence in callback only on this type of route route-map gets applied. Fix: ==== Need to loop through all the route-types in the call back and process the route-map changes. Added a flag to mark which all route-types needs to be processed. Test Executed: =============== 1. Change route-map from permit to deny. 2. Change route-map from deny to permit. 3. Add new route and checked. 4. Verified summarised routes. Risk: ============ Low Signed-off-by: Mobashshera Rasool <[email protected]> (cherry picked from commit 2f43e34)
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20426/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #8954 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/