Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospf6d: fix argument processing in the "area ... range" command #9108

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

rwestphal
Copy link
Member

  • When the "cost" argument isn't present, the default cost should be
    used instead of preserving the previously configured one (if any);
  • When the "not-advertise" argument isn't present, the "not-advertise"
    flag should be unset regardless if it was previously configured or
    not.

Configuration commands should be deterministic and work in the same
way regardless of the current state.

Signed-off-by: Renato Westphal [email protected]

* When the "cost" argument isn't present, the default cost should be
  used instead of preserving the previously configured one (if any);
* When the "not-advertise" argument isn't present, the "not-advertise"
  flag should be unset regardless if it was previously configured or
  not.

Configuration commands should be deterministic and work in the same
way regardless of the current state.

Signed-off-by: Renato Westphal <[email protected]>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 21, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9108 848db95
Date 07/21/2021
Start 14:31:59
Finish 14:57:38
Run-Time 25:39
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-21-14:31:59.txt
Log autoscript-2021-07-21-14:33:12.log.bz2
Memory 490 470 431

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 21, 2021

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20417/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 22, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/9108 b9ff9be
Date 07/21/2021
Start 22:30:52
Finish 22:56:23
Run-Time 25:31
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-21-22:30:52.txt
Log autoscript-2021-07-21-22:32:11.log.bz2
Memory 495 514 429

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20420/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@donaldsharp donaldsharp merged commit 3e18e55 into FRRouting:master Aug 4, 2021
@idryzhov
Copy link
Contributor

idryzhov commented Aug 4, 2021

@Mergifyio backport stable/8.0

@mergify
Copy link

mergify bot commented Aug 4, 2021

Command backport stable/8.0: success

Backports have been created

donaldsharp added a commit that referenced this pull request Aug 5, 2021
ospf6d: fix argument processing in the "area ... range" command (backport #9108)
@eqvinox eqvinox deleted the ospf6d-range-fixes branch August 6, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants