zebra: trigger remove all access vlans info for access port #9091

gord1306 · 2021-07-20T09:30:17Z

When port was removed from last access vlan, the linux kernel won't send any vlan info in the netlink message, it might affect that the evpn mh not withdraw EAD-EVI routes.

polychaeta

Thanks for your contribution to FRR!

One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/4b9d02d2d9233a1b29e575101c2d6190/raw/be1596d14d388f8f15d9f63bf80931a07e91ea61/cr_9091_1626773421.diff | git apply

diff --git a/zebra/if_netlink.c b/zebra/if_netlink.c
index 08ebe14e8..a51e0b82c 100644
--- a/zebra/if_netlink.c
+++ b/zebra/if_netlink.c
@@ -747,7 +747,7 @@ static void netlink_bridge_vlan_update(struct interface *ifp,
 
 	if (af_spec) {
 		for (i = RTA_DATA(af_spec), rem = RTA_PAYLOAD(af_spec);
-				RTA_OK(i, rem); i = RTA_NEXT(i, rem)) {
+		     RTA_OK(i, rem); i = RTA_NEXT(i, rem)) {
 
 			if (i->rta_type != IFLA_BRIDGE_VLAN_INFO)
 				continue;
@@ -762,7 +762,8 @@ static void netlink_bridge_vlan_update(struct interface *ifp,
 			if (!(vinfo->flags & BRIDGE_VLAN_INFO_RANGE_END))
 				vid_range_start = vinfo->vid;
 
-			zebra_vlan_bitmap_compute(ifp, vid_range_start, vinfo->vid);
+			zebra_vlan_bitmap_compute(ifp, vid_range_start,
+						  vinfo->vid);
 		}
 	}

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

blocking comments addressed

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/b79e3b7541b3da59d6859a5f578bcdf1/raw/be1596d14d388f8f15d9f63bf80931a07e91ea61/cr_9091_1626773691.diff | git apply

diff --git a/zebra/if_netlink.c b/zebra/if_netlink.c
index 08ebe14e8..a51e0b82c 100644
--- a/zebra/if_netlink.c
+++ b/zebra/if_netlink.c
@@ -747,7 +747,7 @@ static void netlink_bridge_vlan_update(struct interface *ifp,
 
 	if (af_spec) {
 		for (i = RTA_DATA(af_spec), rem = RTA_PAYLOAD(af_spec);
-				RTA_OK(i, rem); i = RTA_NEXT(i, rem)) {
+		     RTA_OK(i, rem); i = RTA_NEXT(i, rem)) {
 
 			if (i->rta_type != IFLA_BRIDGE_VLAN_INFO)
 				continue;
@@ -762,7 +762,8 @@ static void netlink_bridge_vlan_update(struct interface *ifp,
 			if (!(vinfo->flags & BRIDGE_VLAN_INFO_RANGE_END))
 				vid_range_start = vinfo->vid;
 
-			zebra_vlan_bitmap_compute(ifp, vid_range_start, vinfo->vid);
+			zebra_vlan_bitmap_compute(ifp, vid_range_start,
+						  vinfo->vid);
 		}
 	}

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

When port was removed from last access vlan, the linux kernel won't send any vlan info in the netlink message, it might affact the evpn mh not withdraw EAD-EVI routes. Signed-off-by: Gord Chen <[email protected]>

LabN-CI · 2021-07-20T10:42:41Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/9091 `ec89775`
Date	07/20/2021
Start	06:17:03
Finish	06:42:37
Run-Time	25:34
Total	1813
Pass	1813
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-07-20-06:17:03.txt
Log	autoscript-2021-07-20-06:18:19.log.bz2
Memory	476 497 424

For details, please contact louberger

zebra/if_netlink.c

NetDEF-CI · 2021-07-20T13:52:17Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20376/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for if_netlink.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #765: FILE: /tmp/f1-8339/if_netlink.c:765:

NetDEF-CI · 2021-07-20T14:37:57Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20375/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for if_netlink.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #765: FILE: /tmp/f1-1480/if_netlink.c:765:

NetDEF-CI · 2021-07-20T14:47:00Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20377/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Successful on other platforms/tests

Static analyzer (clang)
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 0
Addresssanitizer topotests part 0
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 9
IPv6 protocols on Ubuntu 18.04
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 1
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 i386 part 7
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 7
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 2
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 2
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 20.04 deb pkg check
Debian 9 deb pkg check
Debian 10 deb pkg check
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 1
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 3

mjstapp · 2021-07-20T14:59:02Z

CI:rerun

mjstapp · 2021-07-20T14:59:15Z

looks like an arm problem - rerunning

NetDEF-CI · 2021-07-20T19:53:12Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20392/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

AnuradhaKaruppiah

Looks good, thx for the fix.

idryzhov · 2021-07-23T09:33:11Z

@Mergifyio backport stable/8.0

mergify · 2021-07-23T09:33:52Z

Command backport stable/8.0: success

Backports have been created

#9159 zebra: trigger remove all access vlans info for access port (backport #9091) has been created for branch stable/8.0

zebra: trigger remove all access vlans info for access port (backport #9091)

polychaeta added the zebra label Jul 20, 2021

polychaeta previously requested changes Jul 20, 2021

View reviewed changes

gord1306 force-pushed the remove_lst_vlan branch from 151c278 to 95098e9 Compare July 20, 2021 09:34

polychaeta reviewed Jul 20, 2021

View reviewed changes

zebra: trigger remove all access vlans for access port

ec89775

When port was removed from last access vlan, the linux kernel won't send any vlan info in the netlink message, it might affact the evpn mh not withdraw EAD-EVI routes. Signed-off-by: Gord Chen <[email protected]>

gord1306 force-pushed the remove_lst_vlan branch from 95098e9 to ec89775 Compare July 20, 2021 09:39

mjstapp reviewed Jul 20, 2021

View reviewed changes

zebra/if_netlink.c Show resolved Hide resolved

mjstapp approved these changes Jul 20, 2021

View reviewed changes

AnuradhaKaruppiah approved these changes Jul 22, 2021

View reviewed changes

donaldsharp merged commit 9fbbcbe into FRRouting:master Jul 22, 2021

mergify bot mentioned this pull request Jul 23, 2021

zebra: trigger remove all access vlans info for access port (backport #9091) #9159

Merged

mwinter-osr added a commit that referenced this pull request Jul 24, 2021

Merge pull request #9159 from FRRouting/mergify/bp/stable/8.0/pr-9091

cc18792

zebra: trigger remove all access vlans info for access port (backport #9091)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zebra: trigger remove all access vlans info for access port #9091

zebra: trigger remove all access vlans info for access port #9091

gord1306 commented Jul 20, 2021

polychaeta left a comment

polychaeta left a comment

LabN-CI commented Jul 20, 2021

NetDEF-CI commented Jul 20, 2021 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jul 20, 2021 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jul 20, 2021 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

mjstapp commented Jul 20, 2021

mjstapp commented Jul 20, 2021

NetDEF-CI commented Jul 20, 2021

AnuradhaKaruppiah left a comment

idryzhov commented Jul 23, 2021

mergify bot commented Jul 23, 2021

zebra: trigger remove all access vlans info for access port #9091

zebra: trigger remove all access vlans info for access port #9091

Conversation

gord1306 commented Jul 20, 2021

polychaeta left a comment

Choose a reason for hiding this comment

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Jul 20, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 20, 2021 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jul 20, 2021 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jul 20, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

mjstapp commented Jul 20, 2021

mjstapp commented Jul 20, 2021

NetDEF-CI commented Jul 20, 2021

Continuous Integration Result: SUCCESSFUL

AnuradhaKaruppiah left a comment

Choose a reason for hiding this comment

idryzhov commented Jul 23, 2021

mergify bot commented Jul 23, 2021

NetDEF-CI commented Jul 20, 2021 •

edited

Loading

NetDEF-CI commented Jul 20, 2021 •

edited

Loading

NetDEF-CI commented Jul 20, 2021 •

edited

Loading