Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospfd: show ip ospf route json does not shown metric and tag #8955

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

mobash-rasool
Copy link
Contributor

ospfd: show ip ospf route json does not shown metric and tag

Problem Statement:
[FRR OSPF] show ip ospf route json does not shown metric and tag.

Root Cause Analysis:
In function show_ip_ospf_route_external, type 2 cost is not added in json.
Hence it is not displayed.

Fix:

  1. Add type2cost in the json display
  2. Tag was also missing, added that as well

Issue: #8729

Signed-off-by: Mobashshera Rasool [email protected]

Problem Statement:
==================
[FRR OSPF] show ip ospf route json does not shown metric and tag.

Root Cause Analysis:
===================
In function show_ip_ospf_route_external, type 2 cost is not added in json.
Hence it is not displayed.

Fix:
=================
1. Add type2cost in the json display
2. Tag was also missing, added that as well

Issue: FRRouting#8729

Signed-off-by: Mobashshera Rasool <[email protected]>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 30, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/8955 67df364
Date 06/30/2021
Start 04:41:55
Finish 05:07:28
Run-Time 25:33
Total 1815
Pass 1815
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-06-30-04:41:55.txt
Log autoscript-2021-06-30-04:43:10.log.bz2
Memory 496 486 430

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19940/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@mjstapp mjstapp merged commit 5537bea into FRRouting:master Jul 2, 2021
@mwinter-osr
Copy link
Member

@Mergifyio backport stable/8.0

@mergify
Copy link

mergify bot commented Jul 23, 2021

Command backport stable/8.0: success

Backports have been created

donaldsharp added a commit that referenced this pull request Jul 23, 2021
ospfd: show ip ospf route json does not shown metric and tag (backport #8955)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants