pimd: make show ip mroute output consistent #8952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polychaeta
reviewed
Jun 29, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/5632137f933ffe238a0575d8096e6b2e/raw/d64c1be034f15589620704b0c1b36d70105aa83e/cr_8952_1624993567.diff | git apply
diff --git a/pimd/pim_cmd.c b/pimd/pim_cmd.c
index bcc05fab3..98eab9b69 100644
--- a/pimd/pim_cmd.c
+++ b/pimd/pim_cmd.c
@@ -6445,8 +6445,8 @@ static void show_mroute(struct pim_instance *pim, struct vty *vty,
if (!uj && !found_oif) {
vty_out(vty,
"%-15s %-15s %-8s %-6s %-16s %-16s %-3d %8s\n",
- src_str, grp_str, "-", proto, in_ifname, "none", 0,
- "--:--:--");
+ src_str, grp_str, "-", proto, in_ifname, "none",
+ 0, "--:--:--");
}
}
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
We had 3 different string output formats in various places. Make them all the same. Signed-off-by: Jafar Al-Gharaibeh <[email protected]>
qlyoung
approved these changes
Jun 29, 2021
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: IncompleteUbuntu 18.04 arm7 build: Incomplete(check logs for details)Ubuntu 18.04 arm7 build: Incomplete(check logs for details)Ubuntu 18.04 ppc64le build: Incomplete(check logs for details)Ubuntu 18.04 arm7 build: Incomplete(check logs for details)Ubuntu 18.04 arm7 build: Incomplete(check logs for details)Ubuntu 18.04 ppc64le build: Incomplete(check logs for details)Ubuntu 16.04 arm8 build: Incomplete(check logs for details)Ubuntu 18.04 arm7 build: Incomplete(check logs for details)Ubuntu 18.04 arm7 build: Incomplete(check logs for details)Ubuntu 18.04 ppc64le build: Incomplete(check logs for details)Ubuntu 18.04 arm7 build: Incomplete(check logs for details)Ubuntu 18.04 arm7 build: Incomplete(check logs for details)Ubuntu 18.04 ppc64le build: Incomplete(check logs for details)Ubuntu 16.04 arm8 build: Incomplete(check logs for details)Ubuntu 16.04 arm7 build: Incomplete(check logs for details)Successful on other platforms/tests
|
Continuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: IncompleteUbuntu 18.04 ppc64le build: Incomplete(check logs for details)Successful on other platforms/tests
|
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
|
@Mergifyio backport stable/8.0 |
|
Command
|
donaldsharp
added a commit
that referenced
this pull request
Aug 17, 2021
pimd: make show ip mroute output consistent (backport #8952)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had 3 different string output formats in various places.
Make them all the same.
Signed-off-by: Jafar Al-Gharaibeh [email protected]