isisd: fix uninitialized variable when searching for LSP

[idryzhov]

Signed-off-by: Igor Ryzhov [email protected]

[riw777]

looks good

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/8902 9ff7c74
Date	06/22/2021
Start	12:03:18
Finish	12:28:50
Run-Time	25:32
Total	1815
Pass	1815
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-06-22-12:03:18.txt
Log	autoscript-2021-06-22-12:04:31.log.bz2
Memory	462 518 427

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19764/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 arm7 build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 18.04 arm7 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19764/artifact/U18ARM7BUILD/ErrorLog/log_pytests.txt
Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19764/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19764/artifact/U18ARM7BUILD/config.status/config.status
Ubuntu 18.04 arm7 build: Unknown Log <frr.xref.xz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19764/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz

Successful on other platforms/tests

• Ubuntu 18.04 i386 build
• Ubuntu 16.04 arm8 build
• Ubuntu 20.04 amd64 build
• Debian 10 amd64 build
• Fedora 29 amd64 build
• Debian 11 amd64 build
• Ubuntu 18.04 amd64 build
• FreeBSD 12 amd64 build
• Ubuntu 16.04 arm7 build
• CentOS 8 amd64 build
• Ubuntu 16.04 i386 build
• Debian 9 amd64 build
• FreeBSD 11 amd64 build
• Ubuntu 18.04 ppc64le build
• Ubuntu 18.04 arm8 build
• NetBSD 8 amd64 build
• OpenBSD 6 amd64 build
• Ubuntu 16.04 amd64 build
• CentOS 7 amd64 build

[qlyoung]

Why is this necessary? The variable is initialized where it is used. We generally avoid 0-initializing variables like this if the 0 doesn't have a semantic value because it allows static analyzers to find places where the value was not set properly (it'll show up as uninitialized value use)

[qlyoung]

Wait, we are casting this to a string. Dumb.

[idryzhov]

Wait, we are casting this to a string. Dumb.

Right, we use it as a string and only set the first two bytes in the code later. We're actually seeing issues because of this - "show isis database detail NAME" doesn't work sometimes.

[idryzhov]

@Mergifyio backport stable/8.0

[mergify]

Command backport stable/8.0: success

Backports have been created

• #9137 isisd: fix uninitialized variable when searching for LSP (backport #8902) has been created for branch stable/8.0