Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Call bgp_dest_unlock_node() inside bgp_adj_in_remove() #8836

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

ton31337
Copy link
Member

No description provided.

@polychaeta polychaeta added the bgp label Jun 11, 2021
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 11, 2021

🛑 Basic BGPD CI results: FAILURE

Results table
_ _
Result FAILURE git merge/8836 6a840fd frr.github Build
Date 06/11/2021
Start 04:11:03
Finish 04:12:18
Run-Time 01:15
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-06-11-04:11:03.txt
Log make-2021-06-11-04:11:03.out.bz2
Memory

For details, please contact louberger

@donaldsharp
Copy link
Member

this looks correct to me.

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19552/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Since bgp_adj_in_set() does the node locking, it makes sense to do the unlocking on bgp_adj_in_remove().

@rwestphal rwestphal merged commit 994624c into FRRouting:master Jun 14, 2021
@ton31337 ton31337 deleted the fix/generalize_bgp_dest_locks branch June 14, 2021 13:14
@mwinter-osr
Copy link
Member

@Mergifyio backport stable/8.0

@mergify
Copy link

mergify bot commented Jul 24, 2021

Command backport stable/8.0: success

Backports have been created

mwinter-osr added a commit that referenced this pull request Jul 24, 2021
bgpd: Call bgp_dest_unlock_node() inside bgp_adj_in_remove() (backport #8836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants