Drop unused code #18243
Merged
Drop unused code #18243
+1
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjstapp
reviewed
Feb 24, 2025
zebra/zebra_dplane.h
Outdated
| @@ -1226,9 +1226,6 @@ struct zebra_dplane_ctx *dplane_provider_dequeue_in_ctx( | |||
| int dplane_provider_dequeue_in_list(struct zebra_dplane_provider *prov, | |||
| struct dplane_ctx_list_head *listp); | |||
|
|
|||
| /* Current completed work queue length */ | |||
| uint32_t dplane_provider_out_ctx_queue_len(struct zebra_dplane_provider *prov); | |||
There was a problem hiding this comment.
hmm, no I'd rather leave this - looks like there's code that accesses this length "raw", and maybe it'd be better to convert that to using the api?
There was a problem hiding this comment.
I'll get Donna to fix this. I missed this when I was looking at the code.
Signed-off-by: Donna Sharp <[email protected]>
Signed-off-by: Donna Sharp <[email protected]>
dksharp5
force-pushed
the
remove_everything
branch
from
66167e4 to
e0387cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete unused functions