Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: Allow fpm_listener to continue to try to read #18049

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

donaldsharp
Copy link
Member

Currently when the fpm_listener attempts to read say X bytes it may only get Y( which is less than X ). In this case we should assume that the dplane_fpm_nl code is just being slow, as that we know it is possible for it to send a partial fpm message. Let's just loosen the constraints a bit and allow data to flow.

@donaldsharp
Copy link
Member Author

ci:rerun

Currently when the fpm_listener attempts to read say X
bytes it may only get Y( which is less than X ).  In this
case we should assume that the dplane_fpm_nl code is just
being slow, as that we know it is possible for it to send
a partial fpm message.  Let's just loosen the constraints
a bit and allow data to flow.

Signed-off-by: Donald Sharp <[email protected]>
Copy link
Contributor

@mjstapp mjstapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure - keep trying

@mjstapp mjstapp merged commit 75bc4a4 into FRRouting:master Feb 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants