zebra: fix evpn rmac nh list cmp function (backport #13854) #13863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
EVPN RMAC (Router MAC) nexthop list compare function needs to return all values so the list element can be compared and added/deleted properly. Ticket:#3486989 Testing Done: Originate EVPN Type-5 route with PIP IP and MAC as remote nexthops. Change the PIP IP address which triggers nexthop change. Before fix: When PIP IP changes RMAC is deleted from remote VTEPs. TORS1# show evpn next-hops vni 4001 | include 00:02:00:00:00:2d 27.0.0.11 00:02:00:00:00:2d TORS1# show evpn rmac vni 4001 | include 00:02:00:00:00:2d 00:02:00:00:00:2d 27.0.0.11 ----- Remote VTEP change nexthop IP to 172.16.16.16 ----- TORS1# show evpn next-hops vni 4001 | include 00:02:00:00:00:2d 172.16.16.16 00:02:00:00:00:2d TORS1# show evpn rmac vni 4001 | include 00:02:00:00:00:2d TORS1# After fix: RMAC is retained as its nexthop list is not empty, thus it is not deleted from remote VTEPs. TORS1# show evpn rmac vni 4001 | include 00:02:00:00:00:2d 00:02:00:00:00:2d 172.16.16.16 Log: 2023/06/27 00:50:36.833474 ZEBRA: [XREH0-ZYMH6] L3VNI 4001 Remote VTEP change(27.0.0.11 -> 172.16.16.16) for RMAC 00:02:00:00:00:2d Signed-off-by: Chirag Shah <[email protected]> (cherry picked from commit a7d77ee)
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 3: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12580/artifact/TP3U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP3U1804AMD64-12580/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3 Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12580/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #13854 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com