tools: Add coccinelle script for hash compare functions NULL values

Signed-off-by: Donatas Abraitis <[email protected]>
FRRouting · Jul 13, 2021 · 107df35 · 107df35
1 parent ce40c62
commit 107df35
Showing 1 changed file with 20 additions and 0 deletions.
diff --git a/tools/coccinelle/hash_compare_null_values_check.cocci b/tools/coccinelle/hash_compare_null_values_check.cocci
@@ -0,0 +1,20 @@
+// There is no need to test for null values in the hash compare
+// function as that we are guaranteed to send in data in
+// the hash compare functions.
+@@
+identifier fn =~ "_hash_cmp";
+type T;
+identifier p1;
+identifier p2;
+@@
+
+?static
+T fn(...)
+{
+...
+- if (p1 == NULL && p2 == NULL)
+-	return ...;
+- if (p1 == NULL || p2 == NULL)
+-	return ...;
+...
+}