Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group peptides by length and check if length is supported in ANN.py #242

Merged
merged 1 commit into from
May 6, 2020

Conversation

skrakau
Copy link
Contributor

@skrakau skrakau commented Apr 2, 2020

Restructured predict() code for MHCnuggets and MHCFlurry to group peptides by length and check if length is supported.

Wait for #240

@skrakau skrakau marked this pull request as ready for review April 30, 2020 16:03

if not result:
raise ValueError("No predictions could be made with " + self.name +
" for given input. Check your epitope length and HLA allele combination.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call it peptide length.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw that's it called epitope everywhere. Keep it like that...


if not result:
raise ValueError("No predictions could be made with " + self.name +
" for given input. Check your epitope length and HLA allele combination.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@christopher-mohr
Copy link
Contributor

Looks good to me 👍

@christopher-mohr christopher-mohr merged commit d0a2c6f into FRED-2:develop May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants