Add support for PULLMODE=NONE to lpf generation #771
Merged
+2
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present the compiler only supports the generation of lpf files containing pin attributes of:
PULLMODE=UP
andPULLMODE=DOWN
.This PR cleans up the code for generating pull modes as well as adding support for generating
PULLMODE=NONE
from apinout.json
file such as:The original implemenation also had a bug whereby pins without a
pullmode
property would be assigned a pullmode ofNONE
:This is incorrect as the default pull mode for a lpf file with no pull mode attribute is
DOWN
.However this did not cause any problems in practice due to the conditional below it which would only generate a
PULLMODE
attribute forUP
andDOWN
: