Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some translation work: fixes and languages #673

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

mgesteiro
Copy link
Contributor

The initial goal was to translate into Spanish the new additions from my previous commits, but I discovered some problems and tried to solve them:

  • Some translation blocks weren't working correctly: they were lost when extracting the labels. After some digging and reading the documentation I managed to solve the issue simplifying how the translation annotations were being made (and correcting them), mainly in the design.html file.
  • Many language files where outdated: after the template is updated, the *.po files should also be updated. There is now a complete English and Spanish translation.
  • The translation percentage table in the README.md wasn't updated: there is now a tool to automate/simplify the process (and is now up to date).
  • Some typos and LOTS of trailing white-spaces and non-uniform indentations.

Please, review this PR carefully and let me know if any change is required.

README.md Show resolved Hide resolved
@cavearr
Copy link
Member

cavearr commented Feb 3, 2023

Hi team!!! you're incredible! i'm reviewed the changes and like a lot, to start to try i merge now but @mgesteiro please read some @TimRudy 's comments about the translations and apply in new pull request i think are very good appointments.

Thanks again!

@cavearr cavearr merged commit ffc0400 into FPGAwars:develop Feb 3, 2023
@mgesteiro
Copy link
Contributor Author

I have checked all @TimRudy comments and will send a new PR with the updates (as you asked @cavearr). Some additional notes:

  • Changes in the en.po file come from changes in the source code: when reviewing this file, please include the commentary line indicating the original source file and line number to go directly to it (helps!)
  • When executing the translation scripts/tools, many files get changed, but that doesn't mean I have done any work on them, so bear with me if something breaks and just let me know to get it fixed.
  • Thanks @TimRudy for the review: I appreciate the effort and time you've put into it.

@TimRudy
Copy link
Contributor

TimRudy commented Feb 3, 2023 via email

@mgesteiro
Copy link
Contributor Author

This reminds me I saw a “python” and perhaps all should be “Python”, thanks

welcome!
I'm learning as I go (English is not my mother language), and "pullup" is also valid (at least dictionary wise), but with idioms (and language in general) is always a very subjective matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants