-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some translation work: fixes and languages #673
Conversation
Hi team!!! you're incredible! i'm reviewed the changes and like a lot, to start to try i merge now but @mgesteiro please read some @TimRudy 's comments about the translations and apply in new pull request i think are very good appointments. Thanks again! |
I have checked all @TimRudy comments and will send a new PR with the updates (as you asked @cavearr). Some additional notes:
|
This reminds me I saw a “python” and perhaps all should be “Python”, thanks
…Sent from my iPhone
On Feb 3, 2023, at 5:49 AM, mgesteiro ***@***.***> wrote:
@mgesteiro commented on this pull request.
In app/resources/locale/en/en.po:
> msgid "Invalid <i>Pull up</i> connection:<br>block already connected"
msgstr "Invalid <i>Pull up</i> connection:<br>block already connected"
-#: app/scripts/services/graph.js:304
+#: app/scripts/services/graph.js:312
msgid "Invalid <i>Pull up</i> connection:<br>only <i>Input</i> blocks allowed"
msgstr "Invalid <i>Pull up</i> connection:<br>only <i>Input</i> blocks allowed"
I prefer pull-up (Arduino influence here). Actually as I'm writing "pullup" github is trying to correct me saying to use "pull-up" or "pull up" 🤦🏽♂️
Tricky word, very context dependent...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
welcome! |
The initial goal was to translate into Spanish the new additions from my previous commits, but I discovered some problems and tried to solve them:
design.html
file.Please, review this PR carefully and let me know if any change is required.