Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the behavior of the sim command to require --testbench flag if more than once benchmark is found. #343

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

zapta
Copy link
Collaborator

@zapta zapta commented Feb 21, 2024

The main change in this PR is in the behavior of the apio sim command. Now, it exists with an error if the --testbench flag is not specified and more than one testbench is found. Also cleaned up the clean logic in the scones scripts and removed the remove a selection by default of ice40 architecture which bit me because of missing two verbose flags in the apio clean commands.

I tested as much as I could with ice40 and ecp5 architectures but could not test end to end due to lack of boards. Overall I feel good about these changes but if anything will come up in testing please ping me.

… is not specified and there is more than one testbench, it exists with an error rather than picking the first testbench. Also tested and simplified the clean logic.
@Obijuan
Copy link
Member

Obijuan commented Feb 21, 2024

Thanks! I will test it on different boards during next weeks

@zapta
Copy link
Collaborator Author

zapta commented Feb 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants