Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PULL_REQUEST_TEMPLATE.md #818

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Create PULL_REQUEST_TEMPLATE.md #818

merged 2 commits into from
Dec 18, 2024

Conversation

jjensen-ebsco
Copy link
Contributor

Purpose

The PR template helps occasional contributors make meaningful PRs.

Changes Made in this PR

Adapted PR template from an ABC repo.

Code Review Specifics

  • Read the code, make suggestions

Task Checklist

  • Ran nox -rs safety.
  • Ran pre-commit run --all-files
  • Tests cover new or modified code.
  • Ran test suite: nox -rs tests -- https://okapi-LATEST_BUGFEST_URI TENANT_ID USERNAME PASSWORD
  • Code runs and outputs default usage info: cd src; poetry run python3 -m folio_migration_tools -h
  • Documentation updated

Warning Checklist

  • New dependencies added
  • Includes breaking changes

How to Verify

No real verification for this. It should just work.

Open Questions

  • Does anything in the CONTRIBUTING.md doc need to change and be reflected here?

Learn Anything Cool?

No.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.19%. Comparing base (07b79a9) to head (415df6a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   72.19%   72.19%           
=======================================
  Files         104      104           
  Lines       11521    11521           
  Branches     1387     1387           
=======================================
  Hits         8318     8318           
  Misses       2904     2904           
  Partials      299      299           
Flag Coverage Δ
unittests 72.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bltravis
Copy link
Collaborator

@jjensen-ebsco I tweaked the checklist item for running tests. We don't need the bugfest information there anymore. The tests don't need to connect to a FOLIO system to run. I'll update CONTRIBUTING.md later.

@bltravis bltravis merged commit 27d099f into main Dec 18, 2024
3 checks passed
@bltravis bltravis deleted the add-pr-template branch December 18, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants