closes #323

[fontanka16]

No description provided.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[bltravis]

I think this looks good. Sorry that I didn't catch the service point thing in your original PR. 😔 More a point of curiosity than anything else, how does the UTC and local midnight reporting work?

[fontanka16]

@bltravis the report thing makes sure to count the things and add them to the migration report. It is not ideal, since by then, it will be too late to do anything about it. But given that we should have performed a test migration before go-live, I think this is acceptable. What do you say?

[bltravis]

👍

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codecov-commenter]

Codecov Report

Merging #324 (f2bf9a0) into main (7d989ab) will decrease coverage by 0.06%.
The diff coverage is 94.87%.

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   60.90%   60.83%   -0.07%     
==========================================
  Files          78       78              
  Lines        7697     7727      +30     
==========================================
+ Hits         4688     4701      +13     
- Misses       3009     3026      +17     

Flag	Coverage Δ
unittests	60.83% <94.87%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/folio_migration_tools/circulation_helper.py	17.46% <ø> (ø)
..._migration_tools/migration_tasks/loans_migrator.py	19.49% <0.00%> (-0.10%)	⬇️
...gration_tools/transaction_migration/legacy_loan.py	76.71% <100.00%> (+1.71%)	⬆️
tests/test_legacy_loan.py	100.00% <100.00%> (ø)
tests/test_loans_migrator.py	100.00% <100.00%> (ø)
src/folio_migration_tools/mapper_base.py	59.67% <0.00%> (-2.69%)	⬇️
...ols/marc_rules_transformation/rules_mapper_base.py	76.87% <0.00%> (-2.50%)	⬇️
...tion_tools/marc_rules_transformation/conditions.py	59.17% <0.00%> (-0.64%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more