Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed bib records file overwritten for each file in bib transformation task #252

Closed
branchedelac opened this issue May 19, 2022 · 1 comment · Fixed by #272
Closed

Failed bib records file overwritten for each file in bib transformation task #252

branchedelac opened this issue May 19, 2022 · 1 comment · Fixed by #272
Assignees
Labels
bug Something isn't working

Comments

@branchedelac
Copy link
Contributor

The unique name of the file, "failed_bib_records_iteration_YYYYMMDD.mrc" is assigned once for the entire task, but the file is actually opened/created anew for every data file included in the task.

The result is that the failed records from data file 1 will be overwritten by those in data file 2, and so on.

image

@branchedelac branchedelac added the bug Something isn't working label May 19, 2022
bltravis added a commit that referenced this issue Jun 2, 2022
@bltravis bltravis self-assigned this Jun 2, 2022
@bltravis
Copy link
Collaborator

bltravis commented Jun 2, 2022

I've created a branch for this fix. Will try to submit the pull request on Thursday. Need to test it with sample data.

@bltravis bltravis linked a pull request Jun 2, 2022 that will close this issue
fontanka16 pushed a commit that referenced this issue Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants