-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistently handle due time for III day loans to avoid duedate earlier outdate error #188
Comments
fontanka16
added a commit
that referenced
this issue
Apr 6, 2022
@branchedelac could you check fcd8fad#diff-6276fd63df8b1563f60b13aa05727af12188396505613c9a8a953311dcd34728 to see if the test covers your use case? |
Actually it does not. I am adding a new test case. |
fontanka16
added a commit
that referenced
this issue
Apr 6, 2022
Now this case is covered as well |
fontanka16
added a commit
that referenced
this issue
Apr 12, 2022
fontanka16
added a commit
that referenced
this issue
Apr 12, 2022
fontanka16
added a commit
that referenced
this issue
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
[Moved from https://github.com/FOLIO-FSE/service_tools/issues/15)
Sierra and Millennium don't export due times.
Parsing the dates as datetime typically translates that to 00:00:00, which for 1-day-loans results in a duedate earlier than outdate error.
Should we be setting all due times to 23:59:59PM (for III and other libraries that don't provide one) to avoid this?
The text was updated successfully, but these errors were encountered: