Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently handle due time for III day loans to avoid duedate earlier outdate error #188

Closed
branchedelac opened this issue Apr 4, 2022 · 3 comments

Comments

@branchedelac
Copy link
Contributor

branchedelac commented Apr 4, 2022

[Moved from https://github.com/FOLIO-FSE/service_tools/issues/15)

Sierra and Millennium don't export due times.

item_barcode	out_date	due_date	renewal_count	status	patron_barcode	next_item_status
789	2019-02-22 10:53:00	2019-02-22	0	n	1234

Parsing the dates as datetime typically translates that to 00:00:00, which for 1-day-loans results in a duedate earlier than outdate error.

item_barcode	out_date	due_date	renewal_count	status	patron_barcode	next_item_status
789	2019-02-22 10:53:00	2019-02-22 00:00:00	0	n	1234

Should we be setting all due times to 23:59:59PM (for III and other libraries that don't provide one) to avoid this?

@fontanka16
Copy link
Contributor

@branchedelac could you check fcd8fad#diff-6276fd63df8b1563f60b13aa05727af12188396505613c9a8a953311dcd34728 to see if the test covers your use case?

@fontanka16
Copy link
Contributor

Actually it does not. I am adding a new test case.

@fontanka16
Copy link
Contributor

Now this case is covered as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants