Pin_colors for 2d_scatter and spatial_plot + Histogram Bin Update function #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…larity and improved logic
Bin Calculation fix to histogram visualization function
Pin_colors for both 2D Scatter and Spatial_plot
Initializing to official repo dev branch
|
Hey @ThomasSheeley, thanks for submitting the request and I do see all tests passed. I see you are creating pull request from dev to dev, which caused conflict to fail to merge. I will close this request, please refer to pull 266 launched from the pin color branch in datamine, please confirm it covers all changes. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin_colors functionality was implemented into 2d_scatter adding additional parameters and logic checks. 2D_scatter was subsequently implemented into spatial_plot in place of the scanpy.pl.spatial() function to add Pin_colors functionality. Histogram bin calculation function that was originally implemented in NIDAP Codeworkbooks is now implemented for the histogram function on github.