Some small fixes to enhance robustness #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens when transcoding with --fit.
Keep_palette works only for PNG but we do not notice PNG good enough now. And because of this, we end up parsing FLIF with ConstantPlanes and it does not work at flif_decode_FLIF2_inner_vertical /_horizontal where we end up casting it as Plane<something>.
|
Maybe there is better way to guard against width/height or rows/cols being 0. These guards are mostly there where issues actually manifest. |
|
I've also pushed fixes3 at https://github.com/maage/FLIF/tree/fixes3, it has some build infra stuff. And also quick and dirty patches to handle situations to notice when FLIF decoding was not okay. My guess is that there is better ways to do that but at least these seem to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.