Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed admin crashes on normal pages #824

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fixed admin crashes on normal pages #824

merged 1 commit into from
Dec 13, 2024

Conversation

johnmeshulam
Copy link
Member

@johnmeshulam johnmeshulam commented Dec 13, 2024 •
edited
Loading

Description

Fixed a bug where admin users division id could not be identified, which caused crashes on multiple pages, notably exports.

Also cleaned up a bunch of code and moved it to layout.tsx

Closes #805

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings

@johnmeshulam johnmeshulam marked this pull request as ready for review December 13, 2024 16:00
@itamaroryan itamaroryan merged commit 356dc13 into main Dec 13, 2024
2 checks passed
@itamaroryan itamaroryan deleted the fix-admin-crashes-on-regular-pages branch December 13, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itamaroryan itamaroryan itamaroryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
LEMS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin user crashes regular user pages
2 participants
@johnmeshulam @itamaroryan