Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #992

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Update dependencies #992

merged 1 commit into from
Dec 20, 2021

Conversation

cmoesel
Copy link
Member

@cmoesel cmoesel commented Dec 20, 2021

Update dependencies to address npm audit. This required changes in the eslint config and jest config as well. I've removed no-use-before-define from .eslintrc because it wasn't working properly and it seemed ok to go w/ the defaults for that one. Any real ordering issues should be caught by tsc anyway (in my experience).

We still get one report in audit (due to cpy-cli), but we've assessed this in the past and confirmed it should not be an issue for us.

Update dependencies to address npm audit.  This required changes in the eslint config and jest config as well.
@cmoesel cmoesel requested a review from jafeltra December 20, 2021 22:18
@jafeltra jafeltra self-assigned this Dec 20, 2021
Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy upgrades ✨

Sad that cpy-cli still hasn't updated though.

@cmoesel cmoesel merged commit 91b76bf into master Dec 20, 2021
@cmoesel cmoesel deleted the dec20-dependency-updates branch December 20, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants