Fix output paths #991
Merged
Fix output paths #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If authors choose ids w/ path separators, they can traverse the output to write to any destination. These tests will only pass if these problematic paths are sanitized.
|
BTW -- I searched the whole code base for all cases where we write files to disk to ensure I had captured all the potential issues. I also ran a full regression and confirmed this does not affect an IGs -- which means that no one was using invalid characters, which is good! |
jafeltra
reviewed
Dec 20, 2021
jafeltra
reviewed
Dec 20, 2021
Co-authored-by: Julia Afeltra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #990.
Since SUSHI uses resource ids and IG ids to name files, it is possible to provide an id w/ path traversal characters (e.g.,
/../../to write to an arbitrary location). Since SUSHI only writesJSONfiles, however, note that this can only be used to write/overwrite files w/ a.jsonextension.You can test this by first checking out only 7c8a745 and confirming the tests do not pass. Then checking out the rest of the branch and confirming the tests pass.
I am also attaching a simple project (NaughtyPaths.zip) that exercises the bug. If you unzip it and run SUSHI on it:
fsh-generated/resources)fsh-generated/resourcesas expected, with problematic characters converted to-.