Insert RuleSet at code path #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An insert rule on a CodeSystem or RuleSet can start with a code path. This allows the code path to act as the context for the rules contained in the inserted RuleSet. When an InsertRule has a code path, it is applied to ConceptRules and CaretValueRules in the inserted RuleSet. An InsertRule with a code path on an entity other than a CodeSystem or RuleSet is syntactically invalid.
mint-thompson
requested review from
cmoesel,
jafeltra,
ngfreiter and
julianxcarter
ngfreiter
suggested changes
Oct 22, 2021
| @@ -28,10 +28,10 @@ vsMetadata: id | title | description; | |||
| vsRule: vsComponent | caretValueRule | insertRule; | |||
| codeSystem: KW_CODESYSTEM name csMetadata* csRule*; | |||
| csMetadata: id | title | description; | |||
| csRule: concept | codeCaretValueRule | insertRule; | |||
| csRule: concept | codeCaretValueRule | codeInsertRule; | |||
There was a problem hiding this comment.
We will want to update the spec with this new grammar, which I think shouldn't be fine, since the grammar is just informative.
When checking if a parser context contains a code path, consider the presence of a RULESET_REFERENCE or PARAM_RULESET_REFERENCE to be sufficient. Although this will include insert rules that contain a regular path, those will also get picked up by containsPathContext, so there are no consequences.
julianxcarter
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes task CIMPL-808.
An insert rule on a CodeSystem or RuleSet can start with a code path. This allows the code path to act as the context for the rules contained in the inserted RuleSet. When an InsertRule has a code path, it is applied to ConceptRules and CaretValueRules in the inserted RuleSet. An InsertRule with a code path on an entity other than a CodeSystem or RuleSet is syntactically invalid.