Update SUSHI --init to avoid publisher errors #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update patient.fsh to have description and example - Update default config to have example publisher - Allow publisher to be overwritten by user
ngfreiter
requested review from
cmoesel,
mint-thompson,
jafeltra and
julianxcarter
mint-thompson
previously approved these changes
Aug 11, 2021
jafeltra
reviewed
Aug 17, 2021
mint-thompson
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884.
sushi --initwas causing errors and warnings in the IG Publisher. These turned out to be related to:MyPatientprofileMyPatientprofilepublishersetSo to fix this, this PR updates the
patient.fshfile to have an example and a description. It also updates the defaultsushi-config.yamlfile to contain default values forpublisher.nameandpublisher.url, and updates theinit()function so that the user can specify custom values for these fields.Testing
To test this, try doing
sushi --initonmaster, and build with the publisher with_genonce. The QA page,output/qa.html, will have several errors and warnings. Then do the same on this branch, and the QA page should look clean, like this:The QA page should definitely be clean if you use default values, and should likely be clean if you use custom values, but note that certain custom values could lead to warnings. But either way make sure to test both approaches. Ensure that the publisher value you use is inserted in the footer of pages as shown here:
