Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for ValueSet compose component without any concept #1540

Merged
merged 10 commits into from
Dec 23, 2024

Conversation

KaelynJefferson
Copy link
Collaborator

Description: This PR adds an improved error message for when there is a code caret rule on ValueSet where the compose component does not have a concept.

Testing Instructions: Run unit tests.

Related Issue: This fixes #1518 .

Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I ran a regression and it doesn't show anyone is hitting this error right now, but it will definitely be helpful for someone writing FSH and running into this.

I just left one small suggestion. Let me know if you agree.

src/export/ValueSetExporter.ts Outdated Show resolved Hide resolved
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good! I've suggested a friendly message to help the user know how to resolve this.

src/export/ValueSetExporter.ts Outdated Show resolved Hide resolved
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @KaelynJefferson!

Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the updates!

@cmoesel cmoesel merged commit 786eb03 into master Dec 23, 2024
14 checks passed
@cmoesel cmoesel deleted the no-concept-error-valueset branch December 23, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message for code caret rule on ValueSet compose component without any concept
3 participants