Fix FSH Finder URL for regression script #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FSH Finder URL changed when FSH School was transferred to HL7. Also improve the error message when there is a problem downloading repo information from FSH Finder.
mint-thompson
approved these changes
Oct 2, 2024
jafeltra
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The FSH Finder URL changed when FSH School was transferred to HL7. As a result, the regression script failed to download repo information from FSH Finder. It also displayed a big ugly error message that was difficult to interpret.
This PR adds better handling for when the FSH Finder download fails and also updates the FSH Finder URL to the new location.
Testing Instructions: Run a regression. You don't need to do a full regression. You could just do:
npm run regression -- run -a gh:master -b local --count 2. You can test the new error handling by changing theFSH_FINDER_URLin the regression script back to its old value and attempt a regression again.Related Issue: N/A