logical/resource root elements set default to prevent empty/missing definition #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaelynJefferson
requested review from
jafeltra,
cmoesel and
mint-thompson
as code owners
cmoesel
reviewed
May 30, 2024
cmoesel
approved these changes
May 31, 2024
There was a problem hiding this comment.
Well done, Kaelyn. This looks great.
I am approving -- but I do have one request: Can you edit this PR's title so it is short enough to fit? And edit the description too since it starts with ...? If you need help w/ figuring out a good (but short) descriptive PR title, feel free to start a conversation w/ the team on Slack.
mint-thompson
approved these changes
Jun 3, 2024
KaelynJefferson
changed the title
KaelynJefferson
added a commit
that referenced
this pull request
Jun 14, 2024
…efinition (#1466) * logical and resource root elements set default to prevent empty or missing definition * Adding in additional test, shorten if-else statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1159
This PR includes:
shortanddefinitionvalues were set by logic described in 1159 and prevents the case of empty/missingdefinition.