Replace type.aggregation on ElementDefinition when modified #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a rule modifies an element or child element of the type.aggregation array, any values on type.aggregation inherited from the parent are completely replaced. Properties of ElementDefinition with this behavior are defined in REPLACEMENT_PROPS.
jafeltra
reviewed
Mar 14, 2024
jafeltra
previously approved these changes
Mar 23, 2024
cmoesel
requested changes
Mar 26, 2024
There was a problem hiding this comment.
This looks good. I think the recent improvements really help a lot.
I tested it with this simple (and technically incorrect) case:
Profile: MyPatient1
Parent: Patient
* name ^type.aggregation[0] = #contained
* name ^type.aggregation[+] = #referenced
Profile: MyPatient2
Parent: MyPatient1
* name ^type.aggregation = #contained
I suggested a few comments to help future me (or future someone else) as they maintain the code. That said, if you think it's not necessary and the comments will just add clutter, then feel free to push back.
jafeltra
approved these changes
Mar 27, 2024
cmoesel
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1411 and completes task CIMPL-1229.
If a rule modifies an element or child element of the type.aggregation array, any values on type.aggregation inherited from the parent are completely replaced. Properties of ElementDefinition with this behavior are defined in REPLACEMENT_PROPS.
No changes appeared in the regression output for this code change.