Quantity may omit numeric value #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the grammar to allow a quantity to omit the numeric value component. Since a ratio contains two quantities, this also affects the allowed FSH for a ratio. A quantity without a numeric value is useful for setting the unit.
cmoesel
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
This works really well. I manually tested it against my own set of cases like this:
https://fshschool.org/FSHOnline/#/share/3V9pUor
It's nice we got support in ratios for free. I think that makes sense. Unfortunately, ratios are a hidden feature in FSH. As far as I can tell, they are not documented in the spec at all. So... we probably should put them into the next ballot.
jafeltra
reviewed
Feb 26, 2024
jafeltra
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes task INT-1241 in alignment with this FSH 3.0 spec change.
Update the grammar to allow a quantity to omit the numeric value component. Since a ratio contains two quantities, this also affects the allowed FSH for a ratio. A quantity without a numeric value is useful for setting the unit.