Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hl7.fhir.uv.extensions autoload to use 'latest' version (v2.x) #1247

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

cmoesel
Copy link
Member

@cmoesel cmoesel commented Mar 27, 2023

With the release of FHIR R5, the hl7.fhir.uv.extensions package got its first official release (1.0.0). As per this conversation, SUSHI and IG Publisher should automatically load the latest published version of hl7.fhir.uv.extensions. Prior to this PR, we autoloaded the current version instead.

Note that I needed to enhance the logic for detecting latest so that it will fall back to packages2.fhir.org if there is no manifest for the package on packages.fhir.org (which is the case for hl7.fhir.uv.extensions).

To test this manually, create an R5 IG. When you run the v2.x branch, you'll see it pull down the current version of hl7.fhir.uv.extensions. When you run this PR branch, you should see it pull down version 1.0.0 instead.

Implements CIMPL-1083.

@cmoesel cmoesel changed the title Change hl7.fhir.uv.extensions autoload to use 'latest' version Change hl7.fhir.uv.extensions autoload to use 'latest' version (v2.x) Mar 27, 2023
Copy link
Collaborator

@mint-thompson mint-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and the change works as expected when I run on an R5 IG. Thank you!

Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version looks good too.

@cmoesel cmoesel merged commit 5e86f57 into v2.x Mar 28, 2023
@cmoesel cmoesel deleted the v2-latest-ext-pkg branch March 28, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants