Warn on empty strings #1158
Merged
Warn on empty strings #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guhanthuran
requested review from
jafeltra,
cmoesel,
julianxcarter and
mint-thompson
as code owners
|
One question for reviewers: should we also add this functionality to |
I don't think we need it on |
cmoesel
reviewed
Oct 19, 2022
Co-authored-by: Chris Moesel <[email protected]>
cmoesel
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087
Adds warnings whenever the user makes their Title or Description an empty string within their Instance, Code System, Structure Definition, or Value Set.
Testers would most likely want to test situations where Title or Description within these types exist but are empty strings.
Thanks for reviewing!