-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct grammar in snapshot missing message #1142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's noticeable if you copy/paste the error message into the Chrome browser - their new spellcheck detection picks it up.
@vadi2 thanks for the PR! This is a nice, simple fix. I ran the automated checks, and it looks like this is failing the check that runs the unit tests. It looks like this test in Once that test is fixed, this PR looks good to me. Our team requires two reviews on PRs, so someone else from our team will review it as well. |
@jafeltra sure, done! I edited the file online using github.dev for convenience, I hope the tests are fine now though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the test! The checks pass, so this looks good to me.
Once another reviewer reviews and approves, we'll merge this in and it will get included in the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vadi2!
No description provided.