Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sushi writes local folder name with \ #299

Closed
keithboone opened this issue Mar 26, 2020 · 7 comments · Fixed by #304
Closed

Sushi writes local folder name with \ #299

keithboone opened this issue Mar 26, 2020 · 7 comments · Fixed by #304
Labels
released Available in an official SUSHI release

Comments

@keithboone
Copy link

I start MY ig.ini in ig-data with:
template= #ig-template

Sushi writes ig.ini as
template= #ig-template

Build fails on IG Builder (I have a workaround for my local build).
cmoesel added a commit that referenced this issue Mar 27, 2020
@cmoesel
Fix handling of local templates in ig.ini
86c4bcb 
Local templates start with # in the ig.ini file, but we were expecting name#version. This fixes it so it works when # is the first character.

Fixes #299.
@cmoesel cmoesel mentioned this issue Mar 27, 2020
Merged
@keithboone
Copy link
Author

Bang! Shooting them down faster than I can find them...

ngfreiter pushed a commit that referenced this issue Mar 27, 2020
@cmoesel
Fix handling of local templates in ig.ini (#304)
f7b38e8 
* Fix handling of local templates in ig.ini

Local templates start with # in the ig.ini file, but we were expecting name#version. This fixes it so it works when # is the first character.

Fixes #299.

* Fix unit test suite name for customized-ig-with-local-template
@keithboone
Copy link
Author

keithboone commented Mar 30, 2020 •
edited
Loading

This still doesn't work in most recent release that I ran.
This is what I have in: fsh\ig-data\ig.ini
[IG]
template = #ig-template
usage-stats-opt-out = false
copyrightyear = 2020+
license = CC-BY-4.0
version = 0.1.0
ballotstatus = CI Build
fhirspec = http://build.fhir.org/

This is what Sushi writes out:
[IG]
ig = input/ImplementationGuide-ainq.fhir.us.saner.json
template = \#ig-template
usage-stats-opt-out = false
copyrightyear = 2020+
license = CC-BY-4.0
version = 0.1.0
ballotstatus = CI Build
fhirspec = http://build.fhir.org/

@keithboone
Copy link
Author

I can either make the CI build work and disable sushi, or make sushi work and break the CI build, but I cannot do both.

@cmoesel
Copy link
Member

cmoesel commented Mar 30, 2020

@keithboone -- is this a different issue now? Based on above it looks like the template value is correct. Are you saying that ig = input/ImplementationGuide-ainq.fhir.us.saner.json is a problem now?

@keithboone
Copy link
Author

keithboone commented Mar 30, 2020 •
edited
Loading

No, I corrected it. The \ didn't show up, I needed to double it in the markdown. See also
http://build.fhir.org/ig/AudaciousInquiry/saner-ig/branches/master/failure/build.log

@cmoesel
Copy link
Member

cmoesel commented Mar 30, 2020

I just cloned your repo and ran SUSHI 0.11.1 against it and the resulting ig.ini file was correct (no extra \). Have you tried it locally (after updating to SUSHI 0.11.1)? It seems to me that maybe the IG Auto Builder is not using the latest greatest SUSHI. I'll ping @jmandel about that.

@keithboone
Copy link
Author

NM: Found it,
it was the difference between
npm install fsh-sushi
and
npm install -g fsh-sushi

I was still a version behind after running the first command.

@cmoesel cmoesel added the released Available in an official SUSHI release label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released Available in an official SUSHI release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of local templates in ig.ini FHIR/sushi
2 participants
@cmoesel @keithboone