fix: remove dependency on when in favor of native Promises #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when is a peculiar library that cannot be bundled by tools like esbuild. Additionally, Promise implementations are available in all currently supported Node releases, so we can remove this dependency whithout impacting user ability to override `promiseFactory`.
|
Of course 👍 Doing it right now, it will trigger a major release though. |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when is a peculiar library that cannot be bundled by tools like esbuild. Additionally, Promise implementations are available in all currently supported Node releases, so we can remove this dependency without impacting user ability to override
promiseFactory.This should fix snowflakedb/snowflake-connector-nodejs#146 and allow other consumers of requestretry to bundle it with esbuild, too.