Tidy coordinate mapping #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscroggs
added a commit
that referenced
this pull request
Jan 19, 2021
* add some debug * Comment out some stuff * Start on libtab_interface * Add simple libtab_interface * flake8 * Add return value to make code compile * Provide more alternatives to fiat_element * Provide more alternatives to fiat_element * tidy and more print debug * Reshape for tensor elements * Removing fiat, adding libtab * libtab * eigen * -dev * Replaceing fiat with libtab * flake * more flake * remove fiat requirement * remove fiat from tests * use libtabbaseelement * Add value_shape TODO * Working on updating dof permutations * Reimplementing more functionality using libtab * return more features * turn off tests for element not implemented yet in libtab * update more tests * get permutation data to pass around correctly * implementing dof permutations * flake * comment out import * entity dofs * vertex quadrature * celltype -> cellname * fixing entity dofs and quadrature * flake * Reimplement more stuff * Get tabulate_reference_basis_derivatives working * remove evaluate_* * flake * remove unused import * contiguous * use fstrings * more fstrings * even more fstrings * missing ) * family names * Remove no longer used code * mt_averaged -> mt.averaged * Reintroduce more functionality * Run demos using pytest * use gcc compilation in demo test * block size corrections * Replace ndofs with dim * Replace ndofs with dim * Added tests that tabulate tensor is correct for Lagrange spaces * install sympy for testing * Put table data from before permutations were applied into conditionals * add interpolation to generated code * correct interpolation and interpolation test * flake * libtab branch * update to match libtab interpolation renaming * add needs_permutation_data to element * correct indices * back to master libtab * interpolation * currect use of subelements * block sizes * Correct interpolation for vectorelement * fix vectorfunctionspace interpolation and evaluation * Add mappings * Add alternative element names * update test to match scalar values * name mapping * skip demos for elements not yes in libtab * fix num_reference_componenets for mixed elements * flake * correct data for mixed and blocked elements * flake * Added permite_dofs_coordinates function * add apply_permutations function * simplify dos permutation application * reflections first * blocking (so mixed elements get correct data * always do reflections first * correct value shapes and sizes of blocked elements * correct blocked tabulation * remove blocksize from value shapes * value shapes * Speed up test * Add curl-curl to get more coverage * back to libtab master * flake8 * correct facet normals for quads * block sizes * libtab -> basix * basix branch * basix branch * ignore test c and h files * update ufc_geometry * remove some unused ufc_geometry * LibtabElement -> BasixElement * add interpolation_is_identity flag * replace reference to fiat with libtab * pass rule into quadrature Correct some geometry * basix branch * correct basix branch name * Remove ufc tabulate_reference_dof_coordinates * switch to main branch * correct quad facet normals * implement cell_vertices * add more to cmap * add mroe info to cmap * swap permutation order for integral tables * reimplement oriented jacobian * use make_perm_data function instead of copy/pasted code * Flake8 fixes * Remove unused code. * Doc fix * tidy up permutations * remove permutations from transform_reference_basis_d * Add docs to ufc.h * remove interpolation functions from finite_element * remove reverse permutation. add permutation of scalar_t data * remove interpolation test (as interpolation is now removed from generated code) * remove tabulate_dof_coordinates * Don't use conditionals * remove interpolation matrix and points from ir * remove physical and reference offsets * Remove transform_values * Remove some unnecessary const in ufc * restore facet_edge_vectors * Tidying up * use scalar_t type inside apply_dof_transformation * remove apply_dof_permutation from coordinate mapping * Revert "remove apply_dof_permutation from coordinate mapping" This reverts commit ea7cbf7. * Tidy coordinate mapping (#297) * add unpermute * un * revert * remove element factory name Co-authored-by: Chris Richardson <[email protected]> Co-authored-by: Garth N. Wells <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.