Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to spdlog #3216

Merged
merged 20 commits into from
May 16, 2024
Merged

Switch to spdlog #3216

merged 20 commits into from
May 16, 2024

Conversation

chrisrichardson
Copy link
Contributor

  • Remove loguru and replace with spdlog

@jhale
Copy link
Member

jhale commented May 16, 2024 •
edited
Loading

This looks good to me apart from having to turn off some warnings. Would it be possible to only turn them off only on GCC (I was told by Chris this only comes up on GCC)? Then we'll still might get some coverage on LLVM/clang toolchains like oneAPI, or people developing on macOS.

@chrisrichardson
Copy link
Contributor Author

Yes I think so.

@garth-wells
Copy link
Member

garth-wells commented May 16, 2024 •
edited
Loading

This looks good to me apart from having to turn off some warnings. Would it be possible to only turn them off only on GCC (I was told by Chris this only comes up on GCC)? Then we'll still might get some coverage on LLVM/clang toolchains like oneAPI, or people developing on macOS.

I don't need to disable the warnings with gcc-13 or gcc-14.

@chrisrichardson
Copy link
Contributor Author

gcc-13 is failing on CI. I have added a check to add the flags for gcc-12 and gcc-13. So this PR should now be good to go, I think.

@chrisrichardson chrisrichardson marked this pull request as ready for review May 16, 2024 10:56
@chrisrichardson chrisrichardson requested a review from jhale May 16, 2024 10:56
garth-wells
garth-wells approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@garth-wells garth-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to add spdlog to Dockerfiles, Spack, Debian and conda.

@chrisrichardson
Copy link
Contributor Author

I already added to Docker files, but will need rebuilding.

@chrisrichardson chrisrichardson added this pull request to the merge queue May 16, 2024
@jhale
Copy link
Member

jhale commented May 16, 2024

Looks good to me, we can deal with packaging afterwards.

Merged via the queue into main with commit b6f80a2 May 16, 2024
28 checks passed
@chrisrichardson chrisrichardson deleted the chris/spdlog branch May 16, 2024 14:05
@garth-wells
Copy link
Member

Resolves #3195

@garth-wells garth-wells mentioned this pull request May 16, 2024
Closed
@jorgensd jorgensd mentioned this pull request May 28, 2024
Merged
jorgensd added a commit to jorgensd/dolfinx_mpc that referenced this pull request May 28, 2024
@jorgensd
API updates (#119)
2c8f1b3 
- Also add some additional `create_connectivity(tdim, tdim)` calls prior to midpoint computations (consequence of FEniCS/dolfinx#3209)
- Switch to spdlog and move some logging to debug mode (FEniCS/dolfinx#3216)
- Support nanobind 2.0.0 (FEniCS/dolfinx#3105)
- Replace `dolfinx.Function.vector` with `dolfinx.Function.x.petsc_vec` (FEniCS/dolfinx#3092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garth-wells garth-wells garth-wells approved these changes

@jhale jhale Awaiting requested review from jhale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisrichardson @jhale @garth-wells