Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pyamg demo #3202

Merged
merged 19 commits into from
May 14, 2024
Merged

Add pyamg demo #3202

merged 19 commits into from
May 14, 2024

Conversation

chrisrichardson
Copy link
Contributor

A simple pyamg example.

@chrisrichardson chrisrichardson marked this pull request as ready for review May 10, 2024 11:14
@chrisrichardson chrisrichardson requested a review from jhale May 10, 2024 11:14
garth-wells
garth-wells reviewed May 11, 2024
View reviewed changes
garth-wells
garth-wells reviewed May 12, 2024
View reviewed changes
Copy link
Member

@garth-wells garth-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This demo is more-or-less a copy of the existing Poisson demo. Could we combine, or maybe we could expand the demo to do more, e.g. add elasticity and used smoothed aggregation AMG?

jorgensd
jorgensd reviewed May 13, 2024
View reviewed changes
@chrisrichardson
Copy link
Contributor Author

This demo is more-or-less a copy of the existing Poisson demo. Could we combine, or maybe we could expand the demo to do more, e.g. add elasticity and used smoothed aggregation AMG?

Yes, now included. Probably needs a little reorganisation - maybe two functions that are called from main?

@garth-wells
Copy link
Member

This demo is more-or-less a copy of the existing Poisson demo. Could we combine, or maybe we could expand the demo to do more, e.g. add elasticity and used smoothed aggregation AMG?

Yes, now included. Probably needs a little reorganisation - maybe two functions that are called from main?

Re-factoring into functions would be good, see related #3076.

@chrisrichardson chrisrichardson added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit b16ef8a May 14, 2024
28 checks passed
@chrisrichardson chrisrichardson deleted the chris/add-pyamg-demo branch May 14, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garth-wells garth-wells garth-wells left review comments

@jorgensd jorgensd jorgensd left review comments

@jhale jhale Awaiting requested review from jhale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisrichardson @garth-wells @jorgensd