Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python version in complex kernel to 3.12 #3199

Merged
merged 2 commits into from
May 6, 2024

Conversation

jorgensd
Copy link
Member

@jorgensd jorgensd commented May 6, 2024

Since we are using ubuntu:24.04 as base now Python version is 3.12

@jorgensd jorgensd requested review from jhale and garth-wells May 6, 2024 07:43
@garth-wells
Copy link
Member

Is there something cleverer we could do so we don't have to change this for each Python update? I had no idea that a change was needed in docker/complex-kernel.json.

@garth-wells garth-wells enabled auto-merge May 6, 2024 07:54
@jorgensd
Copy link
Member Author

jorgensd commented May 6, 2024

Is there something cleverer we could do so we don't have to change this for each Python update? I had no idea that a change was needed in docker/complex-kernel.json.

We tried to reduce the number of places we have this in the code, but last time around I couldn't find a better solution.
(i fixed in the kernels in: #2211)

@garth-wells garth-wells added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit dbbbf91 May 6, 2024
28 checks passed
@garth-wells garth-wells deleted the dokken/bump-python-versions branch May 6, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants