Wrap entities_to_geometry in Python #3038
Conversation
python/dolfinx/mesh.py
Outdated
| dim: Topological dimension of the entities of interest. | ||
| entities: Entity indices (local to the process) to determine the | ||
| vertex geometry indices for. | ||
| orient: If ``True``, in 3D, re-orients facets to have consistent |
There was a problem hiding this comment.
What does this mean? (I know it straight from the C++ docs). @jorgensd?
There was a problem hiding this comment.
This is a flag only used by BEMPP (at least at its introduction) to ensure consistent orientation of each facet (to make all cell normals point outwards).
@mscroggs might be able to comment on the necessity of this at the current stage of BEMPP
There was a problem hiding this comment.
It it's still needed it needs an explanation of what is required for a consistent orientation, i.e. document how we related the normal vector to a facet to the vertex ordering. And does it apply for all facet shapes?
There was a problem hiding this comment.
This is still used by Bempp-cl, so I'm keen to keep it for now. I think we've only tested it for triangle facets, and I'd be keen to work towards removing this once Bempp-rs can do coupling without needing this.
Resolves #3023