-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to demo_helmholtz.py
and demo_scattering_boundary_conditions.py
#2992
Conversation
@BillMaZengou please have a look at GitHub actions status that you see below your message, for instance https://github.com/FEniCS/dolfinx/actions/runs/7551811797/job/20559652794?pr=2992. You'll find that they are failing because of a |
Yes. Sorry for that. The white space was not clear in my IDE. |
It seems that it is automatically updated. Briefly document my steps for future reference (as it is quite difficult to notice whitespace in some IDEs, e.g. Jupyter):
|
demo_helmholtz.py
and demo_scattering_boundary_conditions.py
Thanks @BillMaZengou, this has now been queued for merge by @jorgensd . We may be switching soon to |
Thanks! I will research the format. I did not pay attention to those format before. It has been a good practice for me |
Delete an unused variable in demo_helmholtz.py
Add a description for clarity in demo_scattering_boundary_conditions.py