Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 3rd party logging library #3

Closed
garth-wells opened this issue Apr 10, 2018 · 6 comments
Closed

Use 3rd party logging library #3

garth-wells opened this issue Apr 10, 2018 · 6 comments
Labels
proposal Suggested change or addition

Comments

@garth-wells
Copy link
Member

Replace home-baked logging with a library, e.g..

See also https://neutronsharc.blogspot.co.uk/2016/12/choose-c-logging-library-im-recently.html.

[Opinions of the Boost logging library online are not very positive - heavy weight and slow.]

@garth-wells garth-wells added the proposal Suggested change or addition label Apr 20, 2018
@jhale
Copy link
Member

jhale commented Jan 29, 2019

I'd suggest using spdlog as it now has pybind11-based wrappers: https://github.com/bodgergely/spdlog-python

Would it be best to include the spdlog headers in the DOLFIN source tree or have it as (another) dependency like Eigen?

@garth-wells
Copy link
Member Author

garth-wells commented Feb 5, 2019

See #311.

@garth-wells
Copy link
Member Author

Merged in PR #311.

@jhale jhale reopened this Mar 26, 2019
@jhale
Copy link
Member

jhale commented Mar 26, 2019

spdlog turned out to be very slow at compile time. Other options?

@garth-wells
Copy link
Member Author

Would need to check compile speed for each.

@chrisrichardson
Copy link
Contributor

Using loguru, as it is compatible with Google glog (as are many others), which should make it easy to replace should we need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Suggested change or addition
Projects
None yet
Development

No branches or pull requests

3 participants