-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 3rd party logging library #3
Comments
I'd suggest using spdlog as it now has pybind11-based wrappers: https://github.com/bodgergely/spdlog-python Would it be best to include the spdlog headers in the DOLFIN source tree or have it as (another) dependency like Eigen? |
See #311. |
Merged in PR #311. |
spdlog turned out to be very slow at compile time. Other options? |
Would need to check compile speed for each.
|
Using loguru, as it is compatible with Google glog (as are many others), which should make it easy to replace should we need to. |
Replace home-baked logging with a library, e.g..
See also https://neutronsharc.blogspot.co.uk/2016/12/choose-c-logging-library-im-recently.html.
[Opinions of the Boost logging library online are not very positive - heavy weight and slow.]
The text was updated successfully, but these errors were encountered: