FEXCore: Removes remaining RunningEvents from InternalThreadState #4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are all frontend constructs with mostly deprecated constraints. WaitingToStart isn't used anymore, Running is effectively always true (and behaviour has changed that if a thread is alive, it's running). The only one that remains is `ThreadSleeping` which is only handled in the frontend, and there was some conflation between ThreadSleeping and Running which was hard to gauge. So delete `Running` and `WaitingToStart`, but move `ThreadSleeping` to the frontend.
Sonicadvance1
force-pushed
the
remove_remaining_runningevents
branch
from
a74dbdc to
e7e5920
Compare
lioncash
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all frontend constructs with mostly deprecated constraints.
WaitingToStart isn't used anymore, Running is effectively always true
(and behaviour has changed that if a thread is alive, it's running).
The only one that remains is
ThreadSleepingwhich is only handled inthe frontend, and there was some conflation between ThreadSleeping and
Running which was hard to gauge. So delete
RunningandWaitingToStart, but moveThreadSleepingto the frontend.