unittests/ASM: Fixes x87 80-bit loads on the edge of page boundaries. #4169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, this immediately uncovered a bug in our implementation on the load side. Which is typically a non-problem since long double alignment is 16-byte, but the instructions for loads themselves don't care about alignment. |
Ensures reads don't go past the end of the page boundary. SVE masked loads can make this more effective but `VLoadVectorMasked` isn't setup to be efficient for this case yet.
These tests ensure that FEX's x87 80-bit loadstores don't read/write past the end of the page.
Sonicadvance1
force-pushed
the
x87_loadstore_tests
branch
from
187576b
to
f0d25d4
Compare
|
LGTM. That's an interesting patch - so afaiu the problem was loading 128bit at page boundary. Well, splitting the 128bit into 64+16 bit loads creates a stronger case for |
Sonicadvance1
changed the title
lioncash
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests ensure that FEX's x87 80-bit loadstores don't read/write past the end of the page.
Noticed we were missing testing this edge case a few days ago.