OpcodeDispatcher: Mark CF as being possibly set after inverting #4163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required as if for example CF is non-inverted, code zeroing it doesn't need to mark it as being possibly set, however after inverting it will now be set. To be safe, always mark it as possibly set after inversion.
|
I can only assume the ASM test is breaking since the register state isn't setup coming in to the test. |
|
this is "correct" but I'd like to see if there's a better fix possible, now that CI is up and I can test things again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required as if for example CF is non-inverted, code zeroing it doesn't need to mark it as being possibly set, however after inverting it will now be set. To be safe, always mark it as possibly set after inversion.
Fixes crashes with MaxInst > 2 in Uplay